Homeroom paths: Match by id only, not slug #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
selfie |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
K8 educators with homeroom access
What problem does this PR fix?
This has bitten us twice before: #2022 and #2155. Another case came up again verifying #2584.
In this case, there was a collision between
idandslugspaces for homerooms, which caused the navbar link to be generated with a slug, but be interpreted as if it were an id in the controller lookup code.What does this PR do?
Removes
/homerooms/:slugand only generates and supports/homerooms/:id. There's still a footgun here because theurl_helpers.homeroom_path(homeroom)will use slug, but that's for another day. Verifying #2584 is more important, and this bug makes that more complicated.Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?