Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homeroom navigation: Update navigator to use id, not slug #2589

Merged
merged 4 commits into from Sep 5, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Sep 5, 2019

Following on #2588, this should have been part of that PR.

Who is this PR for?

K8 educators with homeroom access

What problem does this PR fix?

The dropdown on the homeroom page was still using slugs, after #2588 switched to id-only.

What does this PR do?

Fixes bug in making homeroom URL so it uses id.

Also adds Homeroom#grades so that there is a replacement for the deprecated #grade method, and sends it down to the UI. Updates the UI to show this as a suffix, which is helpful anyway and immediately useful for verifying.

Screenshot (if adding a client-side feature)

Screen Shot 2019-09-05 at 10 42 13 AM

Checklists

Which features or pages does this PR touch?

  • Homeroom

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 5, 2019

selfie

@kevinrobinson kevinrobinson merged commit 037229b into master Sep 5, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the patch/homeroom-navigator-id-not-slug branch Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.