Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homerooms: Default grades list to active students only #2590

Merged
merged 1 commit into from Sep 5, 2019

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Sep 5, 2019

Follow-on to #2589. This came up since the homeroom page shows conflicting info in the dropdown (computed from Homeroom#grades) and the description of the homeroom the user is viewing (computed from the list of students, which the server limits to only active students).

@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Sep 5, 2019

selfie

@kevinrobinson kevinrobinson merged commit 1f9b514 into master Sep 5, 2019
1 check passed
@kevinrobinson kevinrobinson deleted the patch/homeroom-grades-active-students branch Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant