Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homerooms: Remove link if no active students #2591

Merged

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Sep 5, 2019

Follow-on to #2589, which used Authorizer#homerooms and filtered out homerooms with no active students. This leads to an edge case where an educator is assigned a homeroom with no active students having a link that doesn't work for them in the navbar. This removes the link in that case - it wouldn't have done anything anyway so this essentially hides stale data coming from the SIS.

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 5, 2019

selfie

@kevinrobinson kevinrobinson merged commit f06f4fa into master Sep 5, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the patch/remove-homeroom-link-if-no-active-students branch Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.