Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homeroom: Remove students_count, update link to require active students #2592

merged 4 commits into from Sep 5, 2019


Copy link

@kevinrobinson kevinrobinson commented Sep 5, 2019

Following-on from #2584.

The semantics of students_count are unlikely to be what a developer wants; usually these should be active students, so let's remove this. Separately fixes a bug in an edge case in production data.

Also optimizes to one SQL query rather than two joined in memory.

Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Sep 5, 2019


@kevinrobinson kevinrobinson merged commit 9f9cec7 into master Sep 5, 2019
1 check passed
@kevinrobinson kevinrobinson deleted the patch/remove-students-count-from-homeroom branch Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant