Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homeroom: Remove students_count, update link to require active students #2592

Merged
merged 4 commits into from Sep 5, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Sep 5, 2019

Following-on from #2584.

The semantics of students_count are unlikely to be what a developer wants; usually these should be active students, so let's remove this. Separately fixes a bug in an edge case in production data.

Also optimizes Educator.active to one SQL query rather than two joined in memory.

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 5, 2019

selfie

@kevinrobinson kevinrobinson merged commit 9f9cec7 into master Sep 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the patch/remove-students-count-from-homeroom branch Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.