Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My students: Add homeroom column and filter #2598

Merged
merged 3 commits into from Sep 9, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Sep 9, 2019

Who is this PR for?

K8 educators with schoolwide access, came up for folks in Bedford

What problem does this PR fix?

No obvious way to filter by homeroom on the "My students" page

What does this PR do?

Adds a column and supports sorting, filtering, and searching.

Factors FilterStudentsBar out from my_students into components, since it was already being re-used by the counselor meeting page. Updates tests for new cases, and for regressions on older cases.

Screenshot (if adding a client-side feature)

image

Checklists

Which features or pages does this PR touch?

  • My students
  • Counselor meetings

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 9, 2019

selfie

@kevinrobinson kevinrobinson merged commit 6c762bc into master Sep 9, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the feature/my-students-homeroom branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.