Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Add thresholds page, update some thresholds #2601

Merged
merged 5 commits into from Sep 10, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Sep 10, 2019

Who is this PR for?

project leads, reading educators

What problem does this PR fix?

Make visible reading thresholds in more visual way.

What does this PR do?

Adds /reading/thresholds with links for project leads with label only.

Also makes some updates to thresholds, which I think were just bugs or inconsistencies. Separately getting more input on that.

Screenshot (if adding a client-side feature)

Screen Shot 2019-09-10 at 5 26 52 PM

Checklists

Which features or pages does this PR touch?

  • Reading
  • Student profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 10, 2019

selfie

@kevinrobinson kevinrobinson merged commit 586b462 into master Sep 10, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the feature/reading-thresholds branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.