Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Fix grade comparison to thresholds in debug view #2602

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Sep 12, 2019

Who is this PR for?

internal team for now

What problem does this PR fix?

On debug page, thresholds are using student's grade now, rather than at the time of the benchmark assessment. This is a wider issue, and separate work will push this upstream to be explicit during import.

What does this PR do?

Updates this for F&P and DIBELs. Also update link to thresholds to point to visual instead of code.

Screenshot (if adding a client-side feature)

image

Checklists

Which features or pages does this PR touch?

  • Reading debug

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 12, 2019

selfie

@kevinrobinson kevinrobinson merged commit f1336cc into master Sep 12, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the patch/reading-debug-grade-then branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.