Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sections: Refactor to allow sections in New Bedford middle schools #2612

Merged
merged 13 commits into from Sep 25, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Sep 19, 2019

Who is this PR for?

New Bedford students, families, educators

What problem does this PR fix?

New Bedford exports only homeroom assignment data from the SIS, but this doesn't work well for most middle school educators. District folks are updating that separately.

When that is fixed, there are assumptions and configuration and product differences that don't make sense for their MS use case. One example is that in Somerville where sections are used, there is always grade data as well. Another issue is that there's no way to deploy in stages, where we import and validate, then enable for authorization.

What does this PR do?

  1. Authorization
    Authorization code now respects PerDistrict#enabled_sections? which can be overridden by an env variable as well.

  2. Endpoints
    The section-related endpoints respect the same method.

  3. Section links
    This adds another layer, PerDistrict#allow_sections_link?, allowing incremental deployment where we enable the feature but don't make it visible to everyone yet.

  4. Student profile UI
    This updates the profile UI to use a different path for New Bedford, where the sections are shown on the profile but without grades like in SHS. This involves changes to LightProfilePage and also pushing code out into PerDistrict.js. EDIT: last commit backs out this actual change for now, to test first

Screenshot (if adding a client-side feature)

Screen Shot 2019-09-19 at 1 20 37 PM

Checklists

Which features or pages does this PR touch?

  • Navbar
  • Student Profile
  • Section
  • My Sections
  • Core

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 25, 2019

selfie

@kevinrobinson kevinrobinson merged commit d5bd6a8 into master Sep 25, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the feature/new-bedford-sections-refactoring branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.