New Bedford: Temporary sections importer#2613
Merged
Merged
Conversation
Contributor
Author
|
selfie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on #2612.
Who is this PR for?
New Bedford students, families and educators
What problem does this PR fix?
In coordinating with district IT folks, we're waiting a bit for some upstream work. This is trying to advance work like #2612 and enable doing some data quality checks on our end, and enable related product changes before the upstream work is done. This PR is mostly risk mitigation against timing on the upstream work.
What does this PR do?
Adds a temporary importer class, using an interim export file format from the district that they'll migrate over to the existing spec formats in the next week or two. So this composes and patches existing importers. If for some reason we need to go forward with the mitigation plan in the next few weeks, we'll need to refactor these to remove things like overriding private methods, but there's no forcing function on that yet.
The work here has been manually verified in different ways, and there's no intention for this to be automated.
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?