Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Bedford: Temporary sections importer #2613

Merged
merged 2 commits into from Sep 25, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Sep 19, 2019

Building on #2612.

Who is this PR for?

New Bedford students, families and educators

What problem does this PR fix?

In coordinating with district IT folks, we're waiting a bit for some upstream work. This is trying to advance work like #2612 and enable doing some data quality checks on our end, and enable related product changes before the upstream work is done. This PR is mostly risk mitigation against timing on the upstream work.

What does this PR do?

Adds a temporary importer class, using an interim export file format from the district that they'll migrate over to the existing spec formats in the next week or two. So this composes and patches existing importers. If for some reason we need to go forward with the mitigation plan in the next few weeks, we'll need to refactor these to remove things like overriding private methods, but there's no forcing function on that yet.

The work here has been manually verified in different ways, and there's no intention for this to be automated.

Checklists

Which features or pages does this PR touch?

  • Section
  • My Sections
  • My Students
  • Core

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 25, 2019

selfie

@kevinrobinson kevinrobinson merged commit 8c4ed6b into master Sep 25, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the feature/new-bedford-section-importer branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.