Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section: Improve header and navigation to other sections #2615

Merged
merged 6 commits into from Sep 20, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Sep 19, 2019

Who is this PR for?

SHS educators, New Bedford educators

What problem does this PR fix?

The section page has an older select box for navigating, and the format of the header doesn't match the way people talk about sections. This was less important when only used by folks at SHS, but more important now that MS folks in New Bedford will use this as well.

What does this PR do?

Updates the header, and replaces the select dropdown with one that allows typing to filter, and is more responsive for larger lists.

Related to #2612, but branching independently to be merged separately.

Screenshot (if adding a client-side feature)

revised header

Screen Shot 2019-09-19 at 5 29 53 PM

navigating to another section

Screen Shot 2019-09-19 at 4 14 22 PM

grades in Somerville

Screen Shot 2019-09-19 at 4 14 53 PM

no grades in New Bedford

Screen Shot 2019-09-19 at 4 14 49 PM

Checklists

Which features or pages does this PR touch?

  • Section

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
@kevinrobinson kevinrobinson force-pushed the feature/section-navigator branch from d1806a8 to c4cc042 Sep 19, 2019
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 20, 2019

selfie

@kevinrobinson kevinrobinson merged commit 92812c7 into master Sep 20, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the feature/section-navigator branch Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.