Section: Improve header and navigation to other sections#2615
Merged
Conversation
kevinrobinson
force-pushed
the
feature/section-navigator
branch
from
d1806a8 to
c4cc042
Compare
Contributor
Author
|
selfie |
This was referenced Sep 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
SHS educators, New Bedford educators
What problem does this PR fix?
The section page has an older select box for navigating, and the format of the header doesn't match the way people talk about sections. This was less important when only used by folks at SHS, but more important now that MS folks in New Bedford will use this as well.
What does this PR do?
Updates the header, and replaces the select dropdown with one that allows typing to filter, and is more responsive for larger lists.
Related to #2612, but branching independently to be merged separately.
Screenshot (if adding a client-side feature)
revised header
navigating to another section
grades in Somerville
no grades in New Bedford
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?