Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Updates for importer in first test runs #2616

Merged
merged 3 commits into from Sep 20, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Sep 20, 2019

Building on @edavidsonsawyer's awesome work in #2523.

Who is this PR for?

Somerville K5 teachers, reading specialists and literacy coaches

What does this PR do?

Some updates to support data quality checks on the initial imports, a bug fix on oral reading fluency column headers, and a UI bug fix on how fall benchmark periods are represented.

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here
@kevinrobinson kevinrobinson changed the title Feature/reading dry run Reading: Updates for importer in first test runs Sep 20, 2019
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 20, 2019

selfie

@kevinrobinson kevinrobinson merged commit 02fad6e into master Sep 20, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the feature/reading-dry-run branch Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.