Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Add validations for different assessments, not yet applied #2621

Merged
merged 4 commits into from Sep 24, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Sep 24, 2019

Adds a validation function for reading data points, not yet applied to the model. This is part of data quality checks on fall assessment data.

It also adds a transformation function in the processor, specifically to handle how importing data produced by formulas works.

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 24, 2019

selfie

@kevinrobinson kevinrobinson merged commit 6cd8842 into master Sep 24, 2019
@kevinrobinson kevinrobinson deleted the patch/reading-validations branch Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.