Reading: Update GoogleSheetsFetcher to recur into folders and batch calls #2623
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
Somerville K5 students, reading specialists, literacy coaches
What problem does this PR fix?
Previous PRs like #2619 #2620 #2621 worked out the kinks running the importer task over individual schools, but running it over the whole district ran into a few issues related to fetching data. First,
#get_tabs_from_folder
assumed that all files within a folder were sheets, but turns out this isn't always the case. Second, it seems that thein parent
query in Google Drive searches only within the immediate "children" of a folder and not recursively which I think I was assuming. Third, when updating to search recursively, we hit API request quotas.What does this PR do?
recursive: true
option to#get_tabs_from_folder
.nil
when calling#values
on a newly added sheet.Does this PR use tests to help verify we can deploy these changes quickly and confidently?