Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Update scoping and sorting for homeroom debug tool #2632

Merged

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Sep 25, 2019

Who is this PR for?

internal team

What problem does this PR fix?

This wasn't showing all homeroom in the range, and sorting was hard to parse quickly.

What does this PR do?

Scopes homerooms to any with students K-5, and moves sorting into UI and updates it for multi-grade rooms.

Screenshot (if adding a client-side feature)

Screen Shot 2019-09-25 at 1 47 46 PM

Checklists

Which features or pages does this PR touch?

  • Reading debug tools

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 25, 2019

selfie

@kevinrobinson kevinrobinson merged commit b261787 into master Sep 25, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the patch/reading-homeroom-debug-scoping-and-sorting branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.