Skip to content

Profile: Adding dialog for seeing who has access - #2637

Merged
kevinrobinson merged 3 commits into
masterfrom
feature/who-has-access
Sep 27, 2019
Merged

Profile: Adding dialog for seeing who has access#2637
kevinrobinson merged 3 commits into
masterfrom
feature/who-has-access

Conversation

@kevinrobinson

Copy link
Copy Markdown
Contributor

Who is this PR for?

internal team, district project leads

What problem does this PR fix?

When changes to permissions are made, there's no way for project leads to directly see who has access to an individual student. Down the line, this is something we'd want to make more visible all around as well, for more distributed review of permissions.

What does this PR do?

Adds a button for seeing this to the student profile, with minimal UI but a more student-centric perspective than other permissions tools. Access is controlled by a label, which will only be set for the internal team (making and reviewing permissions change now), and to project leads to help with that and to help debug any permissions-related issues going forward.

Screenshot (if adding a client-side feature)

Screen Shot 2019-09-26 at 3 24 48 PM

Screen Shot 2019-09-26 at 3 24 39 PM

Screen Shot 2019-09-26 at 3 24 42 PM

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here

@kevinrobinson

Copy link
Copy Markdown
Contributor Author

selfie

@kevinrobinson
kevinrobinson merged commit 0edbae1 into master Sep 27, 2019
@kevinrobinson
kevinrobinson deleted the feature/who-has-access branch September 27, 2019 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant