Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Update importer job for daily automation #2640

Merged

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Sep 27, 2019

Who is this PR for?

K5 reading specialists, literacy coaches, teachers

What problem does this PR fix?

The import of reading data from template sheets is still semi-manual.

What does this PR do?

Adds the importer to the normal set of importer jobs, and sets it up to run for Somerville. Also wraps the importer in a transaction on the table, to cautiously rollback the job in the case of any errors.

Checklists

Which features or pages does this PR touch?

  • Student Profile
  • Import task

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 27, 2019

selfie

@kevinrobinson kevinrobinson merged commit 2f966c6 into master Sep 27, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the feature/reading-benchmark-sheets-importer-automated branch Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.