Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Add safeguards to importer for incremental use #2641

Merged
merged 1 commit into from Sep 27, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Sep 27, 2019

Follow-on to #2640. This removes logging of tab names, which may contain educators names. It also adds a warning about calling the importer with an explicit folder_id, and doesn't call syncer#delete_unmarked_records if an explicit folder is passed.

This prevents against the mistake I just made :) of doing a test run on a subfolder, which then destroyed other records because the scope of the sync is for the whole time period.

It remains to be seen whether recording the URL or doing some other more complex method of setting the sync scope is worthwhile, so for now just adding these guardrails seems best.

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 27, 2019

selfie

@kevinrobinson kevinrobinson merged commit 15edb4c into master Sep 27, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the patch/safeguards-for-reading-importer branch Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.