Reading: Add safeguards to importer for incremental use #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
selfie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #2640. This removes logging of tab names, which may contain educators names. It also adds a warning about calling the importer with an explicit
folder_id, and doesn't callsyncer#delete_unmarked_recordsif an explicit folder is passed.This prevents against the mistake I just made :) of doing a test run on a subfolder, which then destroyed other records because the scope of the sync is for the whole time period.
It remains to be seen whether recording the URL or doing some other more complex method of setting the sync scope is worthwhile, so for now just adding these guardrails seems best.