Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization: Centralize section authorization in Authorizer #2654

Merged
merged 9 commits into from Oct 2, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Oct 1, 2019

Who is this PR for?

K8 educators in New Bedford

What does this PR do?

As we're prepping to release section-based authorization for New Bedford educators, this centralizes all authorization related to Sections into the Authorizer class.

# Example usage:
authorized { Section.all } # authorized
authorized { educator.sections } # assigned

This revises and adds more test cases to verify this all works as expected. Also related to older issue writeups (eg, #1080 (comment)).

Checklists

Which features or pages does this PR touch?

  • Home page
  • Section
  • My Sections
  • My Students
  • Core

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Oct 2, 2019

selfie

@kevinrobinson kevinrobinson merged commit bc285c8 into master Oct 2, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the feature/section-authorization-refactored branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.