Section authorization: Optimize method to make it faster #2656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
Educators with section assignments
What problem does this PR fix?
#2654 centralizes section authorization, and makes more use of these methods that previously. This slowed down the section page for queries like
authorized { Section.all }
.What does this PR do?
Adds two optimizations, adapted from
#why_authorized_for_student?
, comparing foreign key values rather than model values to remove that query, and adding a#to_a
call to the end of the association, which causes Rails to cache the result of that query across calls. I'm not sure why this influences Rails' caching, but it does andPerfTests
here show the same thing as with#why_authorized_for_student?
.Also adds minimal smoke tests to
PerfTest
methods, just verifying that they still run and don't break. It does not make assertions about performance.Screenshot (if adding a client-side feature)
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?