Skip to content

Course and Section imports: Update to use Syncer and revise stats - #2659

Merged
kevinrobinson merged 6 commits into
masterfrom
patch/new-bedford-importer-improvements
Oct 2, 2019
Merged

Course and Section imports: Update to use Syncer and revise stats#2659
kevinrobinson merged 6 commits into
masterfrom
patch/new-bedford-importer-improvements

Conversation

@kevinrobinson

@kevinrobinson kevinrobinson commented Oct 2, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Parts broken off into #2660 and #2661.

This now updates the CourseSectionImporter to use RecordSyncer for both Course and Section models, without changing the update semantics. This has some minor changes for logging and stats as well.

It also inlines the methods in CourseRow and SectionRow into the importer class. In place of the old spec files, it adds integration tests exercising the whole importer class and verifying updates work as expected.

Checklists

Which features or pages does this PR touch?

  • CourseSectionsImporter

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here

@kevinrobinson kevinrobinson changed the title Section imports: Add uniqueness index for Course; more logging on progress Section imports: Add uniqueness index for Course; additional flag for section-based authorizaiton; more logging on progress Oct 2, 2019
@kevinrobinson kevinrobinson changed the title Section imports: Add uniqueness index for Course; additional flag for section-based authorizaiton; more logging on progress Section imports: Add uniqueness index for Course; additional flag for section-based authorization; more logging on progress Oct 2, 2019
@kevinrobinson kevinrobinson changed the title Section imports: Add uniqueness index for Course; additional flag for section-based authorization; more logging on progress WIP (needs breaking up) Section imports: Add uniqueness index for Course; additional flag for section-based authorization; more logging on progress Oct 2, 2019
This was referenced Oct 2, 2019
Merged
Merged
@kevinrobinson

kevinrobinson commented Oct 2, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Closing to do this in smaller pieces.

EDIT: re-opened, with other work pulled out into separate PRs.

@kevinrobinson
kevinrobinson deleted the patch/new-bedford-importer-improvements branch October 2, 2019 20:36
@kevinrobinson
kevinrobinson restored the patch/new-bedford-importer-improvements branch October 2, 2019 20:36
@kevinrobinson kevinrobinson reopened this Oct 2, 2019
@kevinrobinson kevinrobinson changed the title WIP (needs breaking up) Section imports: Add uniqueness index for Course; additional flag for section-based authorization; more logging on progress Course and Section imports: Update to use Syncer and revise stats Oct 2, 2019
@kevinrobinson

kevinrobinson commented Oct 2, 2019

Copy link
Copy Markdown
Contributor Author

selfie

@kevinrobinson
kevinrobinson merged commit 8051a58 into master Oct 2, 2019
@kevinrobinson
kevinrobinson deleted the patch/new-bedford-importer-improvements branch October 2, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kevinrobinson