Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course and Section imports: Update to use Syncer and revise stats #2659

Merged
merged 6 commits into from Oct 2, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Oct 2, 2019

Parts broken off into #2660 and #2661.

This now updates the CourseSectionImporter to use RecordSyncer for both Course and Section models, without changing the update semantics. This has some minor changes for logging and stats as well.

It also inlines the methods in CourseRow and SectionRow into the importer class. In place of the old spec files, it adds integration tests exercising the whole importer class and verifying updates work as expected.

Checklists

Which features or pages does this PR touch?

  • CourseSectionsImporter

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
@kevinrobinson kevinrobinson changed the title Section imports: Add uniqueness index for Course; more logging on progress Section imports: Add uniqueness index for Course; additional flag for section-based authorizaiton; more logging on progress Oct 2, 2019
@kevinrobinson kevinrobinson changed the title Section imports: Add uniqueness index for Course; additional flag for section-based authorizaiton; more logging on progress Section imports: Add uniqueness index for Course; additional flag for section-based authorization; more logging on progress Oct 2, 2019
@kevinrobinson kevinrobinson changed the title Section imports: Add uniqueness index for Course; additional flag for section-based authorization; more logging on progress WIP (needs breaking up) Section imports: Add uniqueness index for Course; additional flag for section-based authorization; more logging on progress Oct 2, 2019
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Oct 2, 2019

Closing to do this in smaller pieces.

EDIT: re-opened, with other work pulled out into separate PRs.

@kevinrobinson kevinrobinson deleted the patch/new-bedford-importer-improvements branch Oct 2, 2019
@kevinrobinson kevinrobinson restored the patch/new-bedford-importer-improvements branch Oct 2, 2019
@kevinrobinson kevinrobinson reopened this Oct 2, 2019
@kevinrobinson kevinrobinson changed the title WIP (needs breaking up) Section imports: Add uniqueness index for Course; additional flag for section-based authorization; more logging on progress Course and Section imports: Update to use Syncer and revise stats Oct 2, 2019
…mporter-improvements
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Oct 2, 2019

selfie

@kevinrobinson kevinrobinson merged commit 8051a58 into master Oct 2, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the patch/new-bedford-importer-improvements branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.