Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sections: Add dialog link for New Bedford, preserving tabs #2670

Merged
merged 2 commits into from Oct 11, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Oct 11, 2019

Building on #2669.

Who is this PR for?

NB project lead, principals

What problem does this PR fix?

Adds a link to see student sections on the profile page for NB. This is different than in SHS, because NB MS students have frequent data from STAR assessments and so the tabs are more valuable than they were originally in SHS, when we changed these to MCAS and collapsed them into one tab to show grades. NB does not send grades, so this isn't changing the core layout and just adding a minimal link up top.

What does this PR do?

link, in header next to grade

Screen Shot 2019-10-11 at 1 14 10 PM

dialog

Screen Shot 2019-10-11 at 1 13 45 PM

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Oct 11, 2019

selfie

@kevinrobinson kevinrobinson merged commit 05f021e into master Oct 11, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the feature/profile-sections-link branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.