Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student meeting importer: Automate import process #2671

Merged
merged 5 commits into from Oct 17, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Oct 17, 2019

Who is this PR for?

SHS students, educators

What problem does this PR fix?

The importer for the student meeting form is semi-automated, so there's some lag between when the conversation happens, and when it appears in Student Insights. For HS folks working with many students, this buries the meeting note in the feed.

What does this PR do?

Updates StudentMeetingImporter to use GoogleSheetsFetcher and to an importer class included as part of the main import task.

Checklists

Which features or pages does this PR touch?

  • Student meeting importer

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Oct 17, 2019

Also bump Brakeman.

@kevinrobinson kevinrobinson merged commit f3f6399 into master Oct 17, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the feature/automate-student-meeting-importer branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.