Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes: Add New Bedford SST for taking notes, in table columns, and search #2672

Merged
merged 2 commits into from Oct 17, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Oct 17, 2019

Who is this PR for?

New Bedford MS educators

What problem does this PR fix?

Some folks in some MS do BBST, some do SST.

What does this PR do?

Updates the PerDistrict.js method to add SST for New Bedford, and then updates the tests. Also adds some missing coverage on this for the school overview table.

Screenshot (if adding a client-side feature)

before

Screen Shot 2019-10-17 at 12 18 13 PM

after

Screen Shot 2019-10-17 at 12 18 05 PM

Checklists

Which features or pages does this PR touch?

  • Student Profile
  • Homeroom
  • Section
  • School Overview

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
@kevinrobinson kevinrobinson changed the title New Bedford SST: Add SST as service for taking notes, in table columns, and search Notes: Add New Bedford SST for taking notes, in table columns, and search Oct 17, 2019
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Oct 17, 2019

selfie

@kevinrobinson kevinrobinson merged commit 0f3fe2a into master Oct 17, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the feature/new-bedford-sst branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.