Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

School roster: Add minimal download CSV button #2673

Merged
merged 5 commits into from Oct 17, 2019
Merged

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Oct 17, 2019

Who is this PR for?

New Bedford MS folks

What problem does this PR fix?

We added this back in 2016 in a particular format as the first way to export to PowerBI, and then removed it in December 2016. We noticed in January 2018 that it wasn't here anymore, but didn't take action since no one was missing it :) I think we didn't immediately re-add it since the old way we used in Healey originally wasn't fast enough for a larger school like Normandin. This past June (#2507) I optimized how this works for a districtwide list, but that was only for project leads so includes things like student address and race that we'd want to scrub from an export on the overview page.

What does this PR do?

This adds CSV download, deferred to user action. We'll deploy and see if it works well enough with large schools, or whether we need to swap to the server side. This doesn't download the exact same data as is shown in the UI; this PR is just aimed at seeing if this works well enough with larger schools.

Also separately updates the server-side export (only exposed to project leads) to use a safelist rather than grabbing all fields on the model.

Screenshot (if adding a client-side feature)

Screen Shot 2019-10-17 at 4 34 03 PM

Screen Shot 2019-10-17 at 4 34 09 PM

Checklists

Which features or pages does this PR touch?

  • School Overview

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes

@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Oct 17, 2019

selfie

@kevinrobinson kevinrobinson merged commit e9bfaa3 into master Oct 17, 2019
1 check passed
@kevinrobinson kevinrobinson deleted the feature/download-csv branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant