Maintenance: Upgrade to node 12#2675
Merged
kevinrobinson merged 1 commit intomasterfrom Oct 22, 2019
Merged
Conversation
Contributor
Author
|
selfie |
1 similar comment
Contributor
Author
|
selfie |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's now in long-term support. The current build setup pins the dev and production node version in
package.json, but floats to the latest LTS in Travis. This means that when a new LTS is released, the build fails like this: https://travis-ci.org/studentinsights/studentinsights/jobs/600978116 This seems fine, and a healthy kind of prompt, so keeping it rather than fixing the version in Travis as well.