Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Upgrade to node 12 #2675

Merged
merged 1 commit into from Oct 22, 2019
Merged

Maintenance: Upgrade to node 12 #2675

merged 1 commit into from Oct 22, 2019

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Oct 22, 2019

It's now in long-term support. The current build setup pins the dev and production node version in package.json, but floats to the latest LTS in Travis. This means that when a new LTS is released, the build fails like this: https://travis-ci.org/studentinsights/studentinsights/jobs/600978116 This seems fine, and a healthy kind of prompt, so keeping it rather than fixing the version in Travis as well.

@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Oct 22, 2019

selfie

1 similar comment
@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Oct 22, 2019

selfie

@kevinrobinson kevinrobinson merged commit 706eecf into master Oct 22, 2019
1 check was pending
@kevinrobinson kevinrobinson deleted the upgrade/node-version branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant