Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sports teams: Automate import, revise template, always include in educator contacts #2677

Merged
merged 4 commits into from Oct 25, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Oct 25, 2019

Who is this PR for?

SHS educators

What problem does this PR fix?

Updates the sports team membership from last year.

What does this PR do?

Updates the import process to be automated for the rest of the year (but scoped to only 2019-2020 for now). Revises the list of educator contacts to always include coaches names (previously it was tied to a feature switch on whether to show icon badges). Update the text on insights related to teams to make more clear which teams they're active on now and which ones are from past seasons.

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Oct 25, 2019

selfie

@kevinrobinson kevinrobinson merged commit 7160b4e into master Oct 25, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.