Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSports teams: Automate import, revise template, always include in educator contacts #2677
Conversation
This comment has been minimized.
This comment has been minimized.
|
selfie |
kevinrobinson
merged commit 7160b4e
into
master
1 check was pending
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kevinrobinson commentedOct 25, 2019
Who is this PR for?
SHS educators
What problem does this PR fix?
Updates the sports team membership from last year.
What does this PR do?
Updates the import process to be automated for the rest of the year (but scoped to only 2019-2020 for now). Revises the list of educator contacts to always include coaches names (previously it was tied to a feature switch on whether to show icon badges). Update the text on insights related to teams to make more clear which teams they're active on now and which ones are from past seasons.
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?