Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAR: Update after breaking changes to vendor export #2681

Merged
merged 6 commits into from Oct 29, 2019

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Oct 29, 2019

Who is this PR for?

Somerville educators

What problem does this PR fix?

The vendor changed export formats (eg, #2526).

What does this PR do?

This makes the minimal update to the new format, and factors out the importer code for reading and math to a single file since it's now the same. This only really makes sense since the current integration is minimal and not expected to change.

Separately, remove instructional_reading_level from StudentAssessment and StarReadingResult since there's no educational or product use for these right now.

Updates the tests to be integration tests, since the refactoring here didn't work with the lower-level testing strategy. Also move star importer bits into their own folder.

Checklists

Which features or pages does this PR touch?

  • STAR importers

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage

@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Oct 29, 2019

selfie

@kevinrobinson kevinrobinson merged commit 5207230 into master Oct 29, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant