Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSTAR: Update after breaking changes to vendor export #2681
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
selfie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kevinrobinson commentedOct 29, 2019
•
edited
Who is this PR for?
Somerville educators
What problem does this PR fix?
The vendor changed export formats (eg, #2526).
What does this PR do?
This makes the minimal update to the new format, and factors out the importer code for reading and math to a single file since it's now the same. This only really makes sense since the current integration is minimal and not expected to change.
Separately, remove
instructional_reading_levelfromStudentAssessmentandStarReadingResultsince there's no educational or product use for these right now.Updates the tests to be integration tests, since the refactoring here didn't work with the lower-level testing strategy. Also move star importer bits into their own folder.
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?