Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAR: Support backwards compatibility too, fix bug with school filter #2682

Merged
merged 3 commits into from Oct 29, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Oct 29, 2019

Who is this PR for?

Builds on #2681.

What problem does this PR fix?

Adds back support for backwards compatibility since New Bedford's format didn't update in the way I had thought. Also fixes bug #2681 introduced with the school filter and adds a test case for it.

Checklists

Which features or pages does this PR touch?

  • STAR importers

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
@kevinrobinson kevinrobinson changed the title Patch/backwards compatible star STAR: Support backwards compatibility too, fix bug with school filter Oct 29, 2019
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Oct 29, 2019

selfie

@kevinrobinson kevinrobinson merged commit 287c1dd into master Oct 29, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the patch/backwards-compatible-star branch Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.