Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: Update Rack:Attack to alert separately for targeted URLs #2691

Merged
merged 3 commits into from Nov 4, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Nov 4, 2019

Who is this PR for?

developers

What problem does this PR fix?

Splitting alerting precedence for different kinds of blocked requests. Also move blocklist/noise rule above datacenter rule to avoid higher-priority alerting on those noise URLs.

Checklists

Which features or pages does this PR touch?

  • Rack attack config

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson kevinrobinson changed the title Patch/rack attack datacenter split Security: Update Rack:Attack to alert separately for targeted URLs Nov 4, 2019
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Nov 4, 2019

selfie

@kevinrobinson kevinrobinson merged commit 3d47f39 into master Nov 4, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the patch/rack-attack-datacenter-split branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.