Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAR: Fix test time since parsing is dependent on time zones, update v1 parsing to ET #2692

Merged

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Nov 4, 2019

What problem does this PR fix?

Tests change based on timezone, since parsing is dependent on EST/EDT, which helpfully changed this weekend. Fixing from #2688.

What does this PR do?

Updates tests to fix time. Also updates v1 parsing to use the same timezone and eastern time expectations. Previously it was fixed at CDT, which I don't think matches what the vendor is doing. Paper trail is: 7b162f3#diff-0e9359cbb9e678e0c8cebe5808671865R33, 71caa90#diff-f371a5d634493de1cbaeb46c77a19048R61 and 0b9208c#r209621059.

Checklists

Which features or pages does this PR touch?

  • STAR importers

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
…for-star-importer-update-to-et
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Nov 4, 2019

selfie

@kevinrobinson kevinrobinson merged commit 11a2393 into master Nov 4, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the patch/fix-timezone-for-star-importer-update-to-et branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.