Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
STAR: Fix test time since parsing is dependent on time zones, update v1 parsing to ET #2692
What problem does this PR fix?
Tests change based on timezone, since parsing is dependent on EST/EDT, which helpfully changed this weekend. Fixing from #2688.
What does this PR do?
Updates tests to fix time. Also updates v1 parsing to use the same timezone and eastern time expectations. Previously it was fixed at CDT, which I don't think matches what the vendor is doing. Paper trail is: 7b162f3#diff-0e9359cbb9e678e0c8cebe5808671865R33, 71caa90#diff-f371a5d634493de1cbaeb46c77a19048R61 and 0b9208c#r209621059.
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?