STAR: Fix test time since parsing is dependent on time zones, update v1 parsing to ET - #2692
Merged
kevinrobinson merged 2 commits intoNov 4, 2019
Conversation
…for-star-importer-update-to-et
Contributor
Author
|
selfie |
kevinrobinson
deleted the
patch/fix-timezone-for-star-importer-update-to-et
branch
November 4, 2019 21:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR fix?
Tests change based on timezone, since parsing is dependent on EST/EDT, which helpfully changed this weekend. Fixing from #2688.
What does this PR do?
Updates tests to fix time. Also updates v1 parsing to use the same timezone and eastern time expectations. Previously it was fixed at CDT, which I don't think matches what the vendor is doing. Paper trail is: 7b162f3#diff-0e9359cbb9e678e0c8cebe5808671865R33, 71caa90#diff-f371a5d634493de1cbaeb46c77a19048R61 and 0b9208c#r209621059.
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?