Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upImport: Close SFTP session more aggressively #2699
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
selfie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kevinrobinson commentedNov 5, 2019
This came up looking at some server logs, and it's been updated on the server side already. This aims to limit the API of
SftpClientto a single method for opening a connection, downloading a file, and closing the connection. In the current implementation, no callers are ever explicitly closing the connection.