Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import: Close SFTP session more aggressively #2699

Merged
merged 1 commit into from Nov 5, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Nov 5, 2019

This came up looking at some server logs, and it's been updated on the server side already. This aims to limit the API of SftpClient to a single method for opening a connection, downloading a file, and closing the connection. In the current implementation, no callers are ever explicitly closing the connection.

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Nov 5, 2019

selfie

@kevinrobinson kevinrobinson merged commit 2fa6153 into master Nov 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the patch/sftp-client-connection-closing branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.