Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMaintenance: Create DistrictConfigLog to enable more self-serve district maintenance #2701
Conversation
kevinrobinson
changed the title
This comment has been minimized.
This comment has been minimized.
|
selfie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kevinrobinson commentedNov 6, 2019
•
edited
For now, this is moving some district configuration that district IT folks provide out of config code and into the database, where it could be stored, viewed and edited in a more self-serve way.
Concretely, that's done by moving where
PerDistrictreads from intoDistrictConfigLog. It typically expresses differences directly in code, reads from ENV variables, or reads config from files likedistrict_somerville.yml.The idea is that
PerDistrictreads secrets and info about services from ENV that's controlled by developers, but that other information (eg, URLs for sheets or drive folders being synced, safelists for particular features, etc) should be read fromDistrictConfigLogwhere it's a step closer to being exposed to project leads and district IT staff.