Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAR: Abort importers if filenames aren't set in config #2705

Merged
merged 3 commits into from Nov 7, 2019

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Nov 7, 2019

The check for remote_file_name being set is too strict for districts that don't use this; this refactors it to work as expected and adds tests for that.

@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Nov 7, 2019

selfie

@kevinrobinson kevinrobinson merged commit 8491caa into master Nov 7, 2019
1 check was pending
@kevinrobinson kevinrobinson deleted the patch/star-importers-abort-if-not-set branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant