Security: Remove use of innerHTML, disallow with linter#2706
Merged
kevinrobinson merged 4 commits intomasterfrom Nov 7, 2019
Merged
Security: Remove use of innerHTML, disallow with linter#2706kevinrobinson merged 4 commits intomasterfrom
kevinrobinson merged 4 commits intomasterfrom
Conversation
kevinrobinson
changed the title
kevinrobinson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
dangerouslySetInnerHTMLin the one place it was used as a shortcut for pasting in SVG without translating to React, and in the other place where it was used for HTML (work board), remove that altogether since it's not used anymore. Also remove use in tests where it was harmless, so we can add https://github.com/mozilla/eslint-plugin-no-unsanitized to the lint setup and fail the build on any use ofinnerHTML. It's only used in one JS test with a bit of a different setup since it loads a fixture of server-rendered HTML.