Services: Move filtering of provider suggestions to client, narrow scope of list#2708
Merged
Merged
Conversation
…ord fixture now mocked
Contributor
Author
|
selfie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
educators
What problem does this PR fix?
The service UI has an old autocomplete, and this worked by querying the server on each keystroke, and filtering a list on the server. That meant unnecessary network chatter, sending user input in the query string (logged in some cases, exposed in some monitoring). There were bugs in the filtering code on the server, and it didn't scope the query to the student's school like it intended (which we wouldn't want anyway, given the complexity of roles).
What does this PR do?
Removes the server filtering, but adds scoping to providers for authorized students. Request the list up front when the UI component is mounted and removes other UI config.
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?