Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Services: Move filtering of provider suggestions to client, narrow scope of list #2708
Who is this PR for?
What problem does this PR fix?
The service UI has an old autocomplete, and this worked by querying the server on each keystroke, and filtering a list on the server. That meant unnecessary network chatter, sending user input in the query string (logged in some cases, exposed in some monitoring). There were bugs in the filtering code on the server, and it didn't scope the query to the student's school like it intended (which we wouldn't want anyway, given the complexity of roles).
What does this PR do?
Removes the server filtering, but adds scoping to providers for authorized students. Request the list up front when the UI component is mounted and removes other UI config.
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?