Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services: Move filtering of provider suggestions to client, narrow scope of list #2708

Merged
merged 6 commits into from Nov 8, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Nov 7, 2019

Who is this PR for?

educators

What problem does this PR fix?

The service UI has an old autocomplete, and this worked by querying the server on each keystroke, and filtering a list on the server. That meant unnecessary network chatter, sending user input in the query string (logged in some cases, exposed in some monitoring). There were bugs in the filtering code on the server, and it didn't scope the query to the student's school like it intended (which we wouldn't want anyway, given the complexity of roles).

What does this PR do?

Removes the server filtering, but adds scoping to providers for authorized students. Request the list up front when the UI component is mounted and removes other UI config.

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Nov 8, 2019

selfie

@kevinrobinson kevinrobinson merged commit 4bc31dd into master Nov 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the patch/simplify-provider-names-autocomplete branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.