Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSTAR: Update config to read from export SFTP box instead of vendor #2712
Conversation
kevinrobinson
changed the title
This comment has been minimized.
This comment has been minimized.
|
selfie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kevinrobinson commentedNov 13, 2019
Who is this PR for?
New Bedford MS educators
What problem does this PR fix?
IT pals in New Bedford are having issues with the STAR setup, either upstream or in working with other vendors. They wanted to work around, so replicated the STAR export themselves.
What does this PR do?
Parameterizes the
StarImporterclasses with methods for getting different clients, and reading config from different places. The New Bedford setup uses this to connect to the SFTP export box rather than STAR directly, and reads the config (which is more sensitive) fromDistrictConfigLoginstead of yaml in source.Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?