Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAR: Update config to read from export SFTP box instead of vendor #2712

Merged
merged 1 commit into from Nov 13, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Nov 13, 2019

Who is this PR for?

New Bedford MS educators

What problem does this PR fix?

IT pals in New Bedford are having issues with the STAR setup, either upstream or in working with other vendors. They wanted to work around, so replicated the STAR export themselves.

What does this PR do?

Parameterizes the StarImporter classes with methods for getting different clients, and reading config from different places. The New Bedford setup uses this to connect to the SFTP export box rather than STAR directly, and reads the config (which is more sensitive) from DistrictConfigLog instead of yaml in source.

Checklists

Which features or pages does this PR touch?

  • STAR importers

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson kevinrobinson changed the title STAR: Update config to read from export SFTP STAR: Update config to read from export SFTP box instead of vendor Nov 13, 2019
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Nov 13, 2019

selfie

@kevinrobinson kevinrobinson merged commit 19e355a into master Nov 13, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the patch/new-bedford-star branch Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.