Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: Fix breaking changes in administrate; remove some code on top #2722

Merged
merged 1 commit into from Dec 5, 2019

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Dec 5, 2019

Who is this PR for?

project leads

What problem does this PR fix?

In the Rails 6 PR, we bumped administrate too. It broke but we missed it. Related to thoughtbot/administrate, 1448.

What does this PR do?

Rebuilds the custom views, removes one altogether and keeps the default except for our navbar up top.

Screenshot (if adding a client-side feature)

Screen Shot 2019-12-05 at 10 15 06 AM

Checklists

Which features or pages does this PR touch?

  • Adjust permissions

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here

@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Dec 5, 2019

selfie

@kevinrobinson kevinrobinson merged commit fc8cd19 into master Dec 5, 2019
1 check was pending
@kevinrobinson kevinrobinson deleted the patch/administrate-custom-views branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant