Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import records: Fix bug blocking districtwide users not set as admin in SIS #2723

Merged
merged 2 commits into from Dec 5, 2019

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Dec 5, 2019

Who is this PR for?

one project lead

What problem does this PR fix?

Some project leads, or other folks with districtwide access, were incorrectly being blocked from accessing some the "SIS import history" tool. This could happen if they didn't have the admin field also set upstream in the SIS at the time of the first account import.

What does this PR do?

Updates to gate this to project leads only. UI code already does that.

Checklists

Which features or pages does this PR touch?

  • District page

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage

@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Dec 5, 2019

selfie

@kevinrobinson kevinrobinson merged commit ee366a9 into master Dec 5, 2019
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant