Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import: Check freshness when downloading file #2747

Merged
merged 3 commits into from Jan 22, 2020

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Jan 22, 2020

Who is this PR for?

developers, district IT staff

What problem does this PR fix?

If there are issues on the district side that prevents export jobs from running, we don't detect automatically when files are stale.

What does this PR do?

Checks the modified timestamp when processing a file fetched through SftpClient.

Checklists

Which features or pages does this PR touch?

  • Importers

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here

@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Jan 22, 2020

selfie

@kevinrobinson kevinrobinson merged commit 4c3763d into master Jan 22, 2020
1 check passed
@kevinrobinson kevinrobinson deleted the patch/check-freshness-before-processing-file branch Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant