Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Show all data points when expanded, add debug link, test all expansions #2754

Merged
merged 2 commits into from Jan 30, 2020

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Jan 30, 2020

Building on #2753

What does this PR do?

  • When expanded, show all data points, not just most recent
  • Add the debug link from the story to the UI, for use with validating production data
  • Update the test and story setup to support expanding all tabs

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here

@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Jan 30, 2020

selfie

@kevinrobinson kevinrobinson merged commit 8a7abfa into master Jan 30, 2020
1 check passed
@kevinrobinson kevinrobinson deleted the patch/simple-box-chart branch Jan 30, 2020
@kevinrobinson kevinrobinson mentioned this pull request Jan 30, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant