Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading: Add coloring to history view, for validating data #2756

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Reading: Add coloring to history view, for validating data #2756

merged 2 commits into from
Jan 30, 2020

Conversation

kevinrobinson
Copy link
Contributor

Building on #2755

What does this PR do?

  • Adds color from Reading: Add BoxChart visual #2755 to the 'debug' grid, for easier validating of data
  • Rename the link from of "debug" to "history" to better reflect what its showing

Screenshot (if adding a client-side feature)

Screen Shot 2020-01-30 at 4 06 42 PM

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here

@kevinrobinson
Copy link
Contributor Author

selfie

@kevinrobinson kevinrobinson merged commit e18c87f into master Jan 30, 2020
@kevinrobinson kevinrobinson deleted the feature/debug-grid-coloring branch January 30, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kevinrobinson