Skip to content

Reading: Add rest of DIBELS materials, allow paging, add thresholds link#2757

Merged
kevinrobinson merged 7 commits into
masterfrom
feature/materials-iteration
Jan 31, 2020
Merged

Reading: Add rest of DIBELS materials, allow paging, add thresholds link#2757
kevinrobinson merged 7 commits into
masterfrom
feature/materials-iteration

Conversation

@kevinrobinson

Copy link
Copy Markdown
Contributor

#2378 What does this PR do?

  • Also refactor grid to improve styling
  • Fixes NWF CLS threshold bug

Screenshot (if adding a client-side feature)

These are unstyled, from Storybook.

materials, paging for multiple images

Screen Shot 2020-01-31 at 1 48 41 PM

thresholds link, dialog inline

Also fixes NWF CLS bug for KF, and adds comments about change to KF winter being optional.
Screen Shot 2020-01-31 at 1 48 54 PM
Screen Shot 2020-01-31 at 1 49 00 PM

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here

@kevinrobinson

Copy link
Copy Markdown
Contributor Author

selfie, going to address build right after (really! :))

@kevinrobinson
kevinrobinson merged commit bb6bb66 into master Jan 31, 2020
@kevinrobinson
kevinrobinson deleted the feature/materials-iteration branch January 31, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant