Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Add rest of DIBELS materials, allow paging, add thresholds link #2757

merged 7 commits into from Jan 31, 2020


Copy link

@kevinrobinson kevinrobinson commented Jan 31, 2020

#2378 What does this PR do?

  • Also refactor grid to improve styling
  • Fixes NWF CLS threshold bug

Screenshot (if adding a client-side feature)

These are unstyled, from Storybook.

materials, paging for multiple images

Screen Shot 2020-01-31 at 1 48 41 PM

thresholds link, dialog inline

Also fixes NWF CLS bug for KF, and adds comments about change to KF winter being optional.
Screen Shot 2020-01-31 at 1 48 54 PM
Screen Shot 2020-01-31 at 1 49 00 PM


Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here

Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Jan 31, 2020

selfie, going to address build right after (really! :))

@kevinrobinson kevinrobinson merged commit bb6bb66 into master Jan 31, 2020
1 check failed
@kevinrobinson kevinrobinson deleted the feature/materials-iteration branch Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant