Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Limit reader profile by grade #2765

Merged
merged 10 commits into from Feb 12, 2020

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Feb 12, 2020

What does this PR do?

Limits the reader profile to students in 5th grade or younger.

Also factors out the older DIBELS and F&P info, into <ReaderProfileDeprecated />, and splits the labels controlling this out from the "june" profile. There are UI tests for this branching now, and updates to the Ruby specs related to labels.

Also updates the tooltip for cohort charts so that it shows more context (primarily for validating data).

Screenshots

Screen Shot 2020-02-12 at 4 21 45 PM

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Added automated tests
  • Manual testing made more sense here

@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Feb 12, 2020

selfie

@kevinrobinson kevinrobinson merged commit f31ee39 into master Feb 12, 2020
1 check was pending
@kevinrobinson kevinrobinson deleted the patch/limit-reader-profile-by-grade branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant