Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Simplify SFTP client params after bug #2772

merged 1 commit into from Feb 27, 2020


Copy link

@kevinrobinson kevinrobinson commented Feb 27, 2020

In #2768 and #2769, there were bugs since the params for this call are a atypical, and end-to-end tests mocked that configuration. We could improve that, but this simplifies the root problem of having to pass a nil override_env param before other config, especially since override_env is never used anywhere :)

Copy link
Contributor Author

kevinrobinson commented Feb 27, 2020


@kevinrobinson kevinrobinson merged commit 9791811 into master Feb 27, 2020
1 check passed
@kevinrobinson kevinrobinson deleted the patch/sftp-client-params branch Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant