Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special education: Add tests cases for current Bedford edge cases #2776

Merged
merged 4 commits into from Feb 28, 2020

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Feb 28, 2020

Who is this PR for?

Bedford educator

What problem does this PR fix?

There's some variation in manual processes for updating data about special education placement, previous identifications of disability, etc. in some upstream systems in Bedford. When Student Insights finds potentially conflicting information like this, it surfaces that in the UI so that folks notice and can bridge any communication gaps.

What does this PR do?

We're not yet sure if we want to keep this, make the "show conflicting information if its ambiguous how to interpret it" strategy more explicit and visible to users within Student Insights, or just address the underlying issues upstream. For now, this just adds two edge cases as test cases, verifying that these are working the way we have come to understand things in some other communication. If we decide on changes, we'll update these to reflect that.

Checklists

Which features or pages does this PR touch?

  • Student Profile
  • School Overview

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Improved specs for existing code in need of better test coverage

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented Feb 28, 2020

selfie

@kevinrobinson kevinrobinson merged commit 746f6b3 into master Feb 28, 2020
1 check passed
@kevinrobinson kevinrobinson deleted the patch/bedford-special-education-edge-cases branch Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant