Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Add STAR reading to comprehension, with box and line chart #2778

Closed
wants to merge 7 commits into from

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Mar 6, 2020

Who is this PR for?

K5 reading folks

What problem does this PR fix?

STAR wasn't included in the reader profile.

What does this PR do?

Adds in a tab, and a view for STAR reading, refactoring a few pieces along the way. Highlighting uses the same heuristic folks decided on in the class lists (<30th percentile), and the code abstracts that out.

Data is provided by updating reader_profile.rb to re-use some of the StudentProfileChartData class for querying and shape of the data. In the UI, parts <BoxChart /> is factored out into pure structural UI elements so it can be re-used here. And the highlighting heuristic is factored out of the class list feature.

No materials are added in this PR.

Screenshot (if adding a client-side feature)

Screen Shot 2020-03-06 at 10 48 53 AM

Screen Shot 2020-03-06 at 10 48 48 AM

Checklists

Which features or pages does this PR touch?

  • Reader profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented Mar 25, 2020

Closing in favor of additional revisions in #2791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant