Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Add F&P materials #2780

Merged
merged 19 commits into from Mar 9, 2020
Merged

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Mar 6, 2020

Who is this PR for?

K5 reading folks

What problem does this PR fix?

There were only a few levels of F&P materials. The overall educational design intent is to support better problem solving by focusing conversation on more concrete and tangible aspects of teaching and learning reading.

What does this PR do?

Adds in images for F&P materials levels A-Z. These are large images, and we can optimize their compression or sizing in a separate pass.

Separately, fixes bug in detecting Storybook and swapping the image asset path (maybe from a Storybook upgrade, not sure).

Adds two stories for looking at these.

Screenshot (if adding a client-side feature)

Story unrolling pages at each level:
Screen Shot 2020-03-06 at 12 24 27 PM

Checklists

Which features or pages does this PR touch?

  • Reader profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented Mar 9, 2020

selfie

@kevinrobinson kevinrobinson merged commit adf7263 into master Mar 9, 2020
1 check passed
@kevinrobinson kevinrobinson deleted the feature/f-and-p-more-materials branch Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant