Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Update rbnacl to resolve ffi deprecation warning #2782

Merged
merged 1 commit into from Mar 17, 2020

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Mar 17, 2020

Follow-on to #2781, which was an automated security patch. It seems the automated patch updated unrelated gems, and while I reviewed the changelog for administrate, I didn't didn't notice the diff updated a bunch of unrelated packages.

One of the changes was to update ffi, which led to this deprecation warning when running tests or deploying:

```[DEPRECATION] Struct layout is already defined for class RbNaCl::HMAC::State. Redefinition as in /Users/me/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/rbnacl-7.1.0/lib/rbnacl/hmac/sha512.rb:105:in `class:State' will be disallowed in ffi-2.0.


So this bumps `rbnacl` to resolve that ([changelog](https://github.com/RubyCrypto/rbnacl/blob/master/CHANGES.md)).

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented Mar 17, 2020

selfie

@kevinrobinson kevinrobinson merged commit 8a2cd2b into master Mar 17, 2020
1 check was pending
@kevinrobinson kevinrobinson deleted the patch/rbnacl-ffi branch Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant