Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Remove sass and bourbon #2784

Merged
merged 1 commit into from Mar 19, 2020
Merged

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Mar 19, 2020

#2783 ended up reaching a threshold for slug size in Heroku (see https://devcenter.heroku.com/articles/slug-compiler#slug-size).

To start I tried cleaning the remote repo (per https://thoughtbot.com/blog/how-to-reduce-a-large-heroku-compiled-slug-size) but that didn't change the size. It did purge the build cache though, which revealed a deprecation notice about sass-ruby. That led me to looking at the Gemfile for sass-rails and bourbon. Neither are needed, since sprockets pulls in sassc are we haven't been using bourbon for a while either. So this removes those gems, which should also reduce the slug size.

There are plenty of other ways to reduce the slug size too, but cleaning up these stale gems is an improvement anyway.

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented Mar 19, 2020

selfie

@kevinrobinson kevinrobinson merged commit 79d885d into master Mar 19, 2020
1 check passed
@kevinrobinson kevinrobinson deleted the patch/prune-sass branch Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant