Repository navigation
Maintenance: Remove sass and bourbon - #2784
Merged
Merged
Conversation
Contributor
Author
|
selfie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2783 ended up reaching a threshold for slug size in Heroku (see https://devcenter.heroku.com/articles/slug-compiler#slug-size).
To start I tried cleaning the remote repo (per https://thoughtbot.com/blog/how-to-reduce-a-large-heroku-compiled-slug-size) but that didn't change the size. It did purge the build cache though, which revealed a deprecation notice about
sass-ruby. That led me to looking at the Gemfile forsass-railsandbourbon. Neither are needed, sincesprocketspulls insasscare we haven't been using bourbon for a while either. So this removes those gems, which should also reduce the slug size.There are plenty of other ways to reduce the slug size too, but cleaning up these stale gems is an improvement anyway.